Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to prevent regressions if BadLayerHandler does not work during packaging or process_projectfile #1089

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add test to prevent regressions if BadLayerHandler does not work during packaging or process_projectfile #1089

merged 1 commit into from
Jan 8, 2025
+2,567 −0

Conversation

gounux
Copy link
Contributor

@gounux gounux commented Dec 20, 2024 •
edited
Loading

This PR will :

  • Create a simple_bumblebees_wrong_localized.qgs QGIS project file with 3 layers :
    • 1 (invalid) layer with a datasource with non existing filename
    • 1 (invalid) localized layer with a datasource with non existing filename
    • 1 (valid) localized layer with a datasource with existing filename (QFC should consider it as invalid because it is localized)
  • Test that a PROCESS_PROJECTFILE type job parses the layer data correctly
  • Test that a PACKAGE type job parses the layer data correctly

@duke-nyuki
Copy link
Collaborator

Task linked: QF-4081 Add test to prevent regressions if BadLayerHandler does not work during packaging or process_projectfile

suricactus
suricactus reviewed Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gounux in case you did not use already, please install https://plugins.qgis.org/plugins/trackable_project_files/ to make the .qgs file git trackable.

@gounux gounux changed the title [WIP] Add test to prevent regressions if BadLayerHandler does not work during packaging or process_projectfile Add test to prevent regressions if BadLayerHandler does not work during packaging or process_projectfile Dec 21, 2024
@gounux gounux marked this pull request as ready for review December 21, 2024 16:39
suricactus
suricactus requested changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments on the test.

@gounux gounux requested a review from suricactus January 4, 2025 11:11
@gounux gounux requested a review from suricactus January 8, 2025 08:34
suricactus
suricactus approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last small comment, please force push with the change and feel free to merge once addressed.

@gounux gounux force-pushed the QF-4081-test-bad-layer-handler-during-jobs branch from e9c9fb7 to 7d52f67 Compare January 8, 2025 13:42
@suricactus suricactus merged commit e91f06b into master Jan 8, 2025
13 checks passed
@suricactus suricactus deleted the QF-4081-test-bad-layer-handler-during-jobs branch January 8, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gounux @duke-nyuki @suricactus